Copy only YAML files when syncing CRDs - #5307
Merged
caseydavenport merged 1 commit intoSep 10, 2026
Merged
Conversation
The upstream CRD directories also hold Go source, which is not CRD content.
caseydavenport
added
docs-not-required
kind/bug
This was referenced Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix. The CRD sync copies every file out of the upstream CRD directories, so it picked up the Go files that sit alongside the generated YAML. The operator parses everything in those directories as CRDs, which made it panic at startup and fail
make test-crds, the unit tests, and the FVs. This restricts the copy to YAML files.Verified locally:
make gen-versionsleaves a clean tree, and both--print-enterprise-crds alland--print-calico-crds allexit 0. Reproduced the panic first on the head of #5298.Affects the version sync only, not the shipped operator.
Release Note
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.